[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77509





--- Comment #26 from Chris Rogers <crogers at google.com>  2012-02-10 13:26:56 PST ---
(From update of attachment 126449)
View in context: https://bugs.webkit.org/attachment.cgi?id=126449&action=review

Overall looks pretty good!  I'm glad the layout tests are now passing

> Source/WebCore/platform/audio/Biquad.cpp:256
> +    setNormalizedCoefficients(m_b0, m_b1, m_b2, 1, m_a1, m_a2);

It seems odd that we first set the values directly on the member variables in this method, then call setNormalizedCoefficients().

Can we improve this in this method and setHighpassParams() and any similar methods to be more consistent and similar to what we do in setLowShelfParams()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.