[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

Fri Feb 10 13:35:20 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=77509

--- Comment #27 from Raymond Toy <rtoy at chromium.org>  2012-02-10 13:35:20 PST ---
(From update of attachment 126449)
View in context: https://bugs.webkit.org/attachment.cgi?id=126449&action=review

LGTM

> LayoutTests/webaudio/resources/biquad-testing.js:73
> +        a2 = 0;

nit: Can you explain why this is needed now when it wasn't needed without IPP?  When I run this with freq = 0 (and q = 1 and gain = 1) I get b0=b1=b2=0 and a1=-2 and a2=1.  Is it because there's a pole at 1?

> LayoutTests/webaudio/resources/biquad-testing.js:386
> +    var a2 = filterCoef.a2;

Sorry about that.  I'm surprised this worked at all before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.