[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

Mon Feb 6 06:08:12 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=73215

--- Comment #51 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-02-06 06:08:12 PST ---

> I don't see any code in this patch calling these newly added functions, so it looks like adding dead code. Should they perhaps be part of another patch that adds them when they're needed? (as-is they are not even callable in QML)

Yeah, adding this with a test (lets say using geolocation from a local qrc file?) would rock.

> > Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h:37
> > +    Q_PROPERTY(QtWebSecurityOrigin* origin READ securityOrigin)
> 
> Any particular reason to call the property "origin" but the getter function (and class) is called _security_Origin?

origin is a better name... it is the origin of the premission request and origin also fits better with the CORS spec (cross-origin...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.