[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #50 from Simon Hausmann <hausmann at webkit.org>  2012-02-06 06:04:57 PST ---
(From update of attachment 124943)
View in context: https://bugs.webkit.org/attachment.cgi?id=124943&action=review

This is much much better :-). A few comments/questions.

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:55
> +    static void addLocalScheme(const QString& scheme);
> +    static void removeLocalScheme(const QString& scheme);
> +    static QStringList localSchemes();

I don't see any code in this patch calling these newly added functions, so it looks like adding dead code. Should they perhaps be part of another patch that adds them when they're needed? (as-is they are not even callable in QML)

> Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h:37
> +    Q_PROPERTY(QtWebSecurityOrigin* origin READ securityOrigin)

Any particular reason to call the property "origin" but the getter function (and class) is called _security_Origin?

> Source/qtwebkit-export.map:161
> +        *QtWebSecurityOrigin;
> +        non-virtual?thunk?to?QtWebSecurityOrigin*;
> +        QtWebSecurityOrigin::*;

Thankfully this file is gone and this hunk won't be needed anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.