[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 10:58:55 PST 2012


--- Comment #33 from Tony Chang <tony at chromium.org>  2012-02-03 10:58:55 PST ---
(From update of attachment 125242)
View in context: https://bugs.webkit.org/attachment.cgi?id=125242&action=review

Just some small nits left. Otherwise, the gyp changes look good to me.

Chris, do the code changes look good to you?

> Source/WebCore/WebCore.gyp/WebCore.gyp:2001
> +          'all_dependent_settings': {

I don't think you need all_dependent_settings here.  I think gyp is smart enough to copy link_settings down to the targets that need it.

> Source/WebCore/WebCore.gyp/WebCore.gyp:2004
> +            'ldflags': [
> +              '<!@(pkg-config --libs-only-L ipp)',
> +            ],

Doesn't this have to go in link_settings?  That's what I see for other uses of ldflags.  See Source/WebKit/chromium/build/linux/system.gyp for other examples.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list