[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75522





--- Comment #32 from xingnan.wang at intel.com  2012-02-02 19:34:56 PST ---
(In reply to comment #30)
> (From update of attachment 124867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124867&action=review
> 
> > Source/WebCore/WebCore.gyp/WebCore.gyp:1357
> > +        ['OS=="linux" and "WTF_USE_WEBAUDIO_IPP=1" in feature_defines', {
> > +          'cflags': [
> > +            '<!@(pkg-config --cflags-only-I ipp)',
> 
> Does this need to be here in the webcore_prerequisite targets section?  Since this target doesn't compile any files, this probably doesn't do anything.  However, I think if you added a direct_dependent_settings section, the cflags will be used by the other webcore targets.  Which means you wouldn't need to have the other cflags sections below.  E.g., this could be:
> 
> ['OS=="linux" and "WTF_USE_WEBAUDIO_IPP=1" in feature_defines', {
>   'direct_dependent_settings': {
>     'cflags': [
>       '<!@(pkg-config --cflags-only-I ipp)',
>     ],
>   },
> }],
> 
> > Source/WebCore/platform/audio/FFTFrame.h:57
> > +#include "ipps.h"
> 
> Nit: Should we use <ipps.h> since it's a system header?

Tony, thanks your comments, patch is updated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.