[Webkit-unassigned] [Bug 76181] [GTK] FullScreen signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76181





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2012-02-02 03:40:13 PST ---
(In reply to comment #8)
> > Tools/GtkLauncher/main.c:146
> > +        g_signal_connect_swapped(dialog, "response", G_CALLBACK(gtk_widget_destroy), dialog);
> > +        g_timeout_add(1500, (GSourceFunc) webViewFullscreenMessageWindowClose, dialog);
> > +        gtk_dialog_run(GTK_DIALOG(dialog));
> 
> This is blocking and dialog is modal, so you don't need to connect to response nor to add the timeout, just destroy the dialog after dialog_run()
> 

I need that code to close the popup even if the user doesn't explicit close it.

> 
> > Tools/GtkLauncher/main.c:176
> > +        g_signal_connect(topLevelWindow, "window-state-event", G_CALLBACK(webViewWindowStateEvent), webView);
> 
> I wonder whether the default impl for entering/leaving fullscreen should happen in the object method handler instead of after emitting the signal. That way, you could connect to entering-fullscreen with g_signal_connect to show the confirm dialog, and g_signal_connect_after to show the information dialog.
> 

Hum, I'll experiment with that!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.