[Webkit-unassigned] [Bug 76181] [GTK] FullScreen signals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 04:07:37 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76181





--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2012-02-02 04:07:38 PST ---
(In reply to comment #10)
> > 
> > > Tools/GtkLauncher/main.c:176
> > > +        g_signal_connect(topLevelWindow, "window-state-event", G_CALLBACK(webViewWindowStateEvent), webView);
> > 
> > I wonder whether the default impl for entering/leaving fullscreen should happen in the object method handler instead of after emitting the signal. That way, you could connect to entering-fullscreen with g_signal_connect to show the confirm dialog, and g_signal_connect_after to show the information dialog.
> > 
> 
> Hum, I'll experiment with that!

So you meant doing gtk_window_fullscreen() in webkit_web_view_real_entering_fullscreen() and the opposite in webkit_web_view_real_leaving_fullscreen()?

If so, that doesn't work and looks awkward, actually. Also if the UA blocks the entering-fullscreen signal the element remains zoomed-out in the un-fullscreened window.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list