[Webkit-unassigned] [Bug 104628] Milliseconds field of date/time input UI should respect step attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104628





--- Comment #5 from Kunihiko Sakamoto <ksakamoto at chromium.org>  2012-12-11 21:48:57 PST ---
(From update of attachment 178709)
Thanks for the review.
Updated patch with tests. Please take another look.

View in context: https://bugs.webkit.org/attachment.cgi?id=178709&action=review

>> Source/WebCore/html/shadow/DateTimeEditElement.cpp:220
>> +        RefPtr<DateTimeNumericFieldElement> field = DateTimeMillisecondFieldElement::create(document, m_editElement, step);
> 
> We should take account of non-zero step-base value.  e.g. <input type=time step=0.100 min=00:00:00.050>
> We need to pass step-base value (the milliseconds part of the min), or stop step-aware behavior if step-base is not zero.

Changed to pass step-base value.

>> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:71
>>      // We show a direction-neutral string such as "--" as a placeholder. It
> 
> We should have ASSERT(m_step).

Done.

>> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:199
>>          setValueAsInteger(defaultValueForStepDown(), DispatchEvent);
> 
> defaultValueForStepDown() needs to be aligned to m_step.

Done.

>> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:212
>>          setValueAsInteger(defaultValueForStepUp(), DispatchEvent);
> 
> defaultValueForStepUp() needs to be aligned to m_step.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.