[Webkit-unassigned] [Bug 104628] Milliseconds field of date/time input UI should respect step attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104628


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178961|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Kent Tamura <tkent at chromium.org>  2012-12-11 22:29:12 PST ---
(From update of attachment 178961)
View in context: https://bugs.webkit.org/attachment.cgi?id=178961&action=review

> Source/WebCore/ChangeLog:11
> +        Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

You need to add tests for
  step=0
  step=0.00001

> Source/WebCore/html/shadow/DateTimeEditElement.cpp:221
> +        if (decimalMsPerSecond.remainder(m_parameters.stepRange.step()).isZero()) {

You need to check m_parameters.stepRange.step().remainder(Decimal(1)).isZero() too.

> Source/WebCore/html/shadow/DateTimeEditElement.cpp:223
> +            stepBase = static_cast<int>(m_parameters.stepRange.stepBase().remainder(decimalMsPerSecond).toDouble());

Why don't you subtract msPerSecond from the remainder result and assume stepBase<=0 ?  It would make roundUp/roundDown simpler.

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:82
> +shouldBeEqualToString('stepDown("07:13:00.500", 0.100, "00:00:00.050", null)', '07:13:00.450');
> +

We should test rounding of defaultValeuForStepDown/Up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.