[Webkit-unassigned] [Bug 104360] Coordinated Graphics: Separate LayerTreeCoordinator into LayerTreeCoordinator and CompositingCoordinator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 16:49:40 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104360





--- Comment #12 from Huang Dongsung <luxtella at company100.net>  2012-12-11 16:52:02 PST ---
I read IRC discussion with noamr and ryumiel. your opinions are very reasonable. I want to stack a bit idea on your opinions.

I prefer keeping three class: CoordinatedLayerTreeHost, CompositingCoordinator and WebCompositingCoordinatorOperations (extends CompositingCoordinatorOperations)

The role description is
CoordinatedLayerTreeHost : LayerTreeHost for Coordinated Graphics
CompositingCoordinator : Managing the lifecycle, root layer and etc. It will be reused in both WK1 and WK2.
CompositingCoordinatorOperations : Operations to communicate with LayerTreeRenderer.
WebCompositingCoordinatorOperations : IPC-based CompositingCoordinatorOperations implementaion.

CoordinatedLayerTreeHost can extend CompositingCoordinatorOperations, but it makes CoordinatedLayerTreeHost play many roles. I prefer that CoordinatedLayerTreeHost has a minimal role: LayerTreeHost.

If ryumiel choose this suggestion, ryumiel need to move some code from WebCompositingCoordinatorOperations to CoordinatedLayerTreeHost. CoordinatedLayerTreeHost should send messages to UI Process by itself. I think CoordinatedLayerTreeHost does not need to have a WebCompositingCoordinatorOperations member. After setting WebCompositingCoordinatorOperations to CompositingCoordinator, CoordinatedLayerTreeHost should not use WebCompositingCoordinatorOperations anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list