[Webkit-unassigned] [Bug 104360] Coordinated Graphics: Separate LayerTreeCoordinator into LayerTreeCoordinator and CompositingCoordinator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104360





--- Comment #13 from Noam Rosenthal <noam at webkit.org>  2012-12-11 22:23:30 PST ---
(In reply to comment #12)
> I read IRC discussion with noamr and ryumiel. your opinions are very reasonable. I want to stack a bit idea on your opinions.
> 
> I prefer keeping three class: CoordinatedLayerTreeHost, CompositingCoordinator and WebCompositingCoordinatorOperations (extends CompositingCoordinatorOperations)
> 
> The role description is
> CoordinatedLayerTreeHost : LayerTreeHost for Coordinated Graphics
> CompositingCoordinator : Managing the lifecycle, root layer and etc. It will be reused in both WK1 and WK2.
> CompositingCoordinatorOperations : Operations to communicate with LayerTreeRenderer.
> WebCompositingCoordinatorOperations : IPC-based CompositingCoordinatorOperations implementaion.

My issue is mainly with CompositingCoordinatorOperations. I don't like that it's a bunch of virtual functions; instead it should be a list of operations, with a type and parameters, that we encode/decode in WebKit2.
So, CoordinatedLayerTreeHost and CompositingCoordinator are pretty clear,
but I would have CoordinatedLayerTreeHost deal with e.g. converting a CoordinatedSurface inside CompositingCoordinatorOperations and converting it to a handle, rather than have an additional WebCompositingCoordinatorOperations class for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.