[Webkit-unassigned] [Bug 105342] [Mac] Remove Platform.h macros from WebKit Private Headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105342


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ddkilzer at webkit.org




--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2012-12-21 14:50:50 PST ---
(In reply to comment #0)
> Note: the top 2 instances are actual uses, the rest appear to be directly defined flags. If those are safe, the script should be updated to not consider those errors.
> 
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDashboardRegion.h:26' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_DASHBOARD_SUPPORT)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDashboardRegion.h:27' included forbidden macro 'ENABLE' => '#define ENABLE_DASHBOARD_SUPPORT 1'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDashboardRegion.h:30' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebFramePrivate.h:34' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_NETSCAPE_PLUGIN_API)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebFramePrivate.h:35' included forbidden macro 'ENABLE' => '#define ENABLE_NETSCAPE_PLUGIN_API 1'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebFramePrivate.h:90' included forbidden macro 'ENABLE' => '#if ENABLE_NETSCAPE_PLUGIN_API'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebHTMLViewPrivate.h:31' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_NETSCAPE_PLUGIN_API)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebHTMLViewPrivate.h:32' included forbidden macro 'ENABLE' => '#define ENABLE_NETSCAPE_PLUGIN_API 1'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebHTMLViewPrivate.h:112' included forbidden macro 'ENABLE' => '#if ENABLE_NETSCAPE_PLUGIN_API'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:31' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_PLUGIN_PROXY_FOR_VIDEO)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:32' included forbidden macro 'ENABLE' => '#define ENABLE_PLUGIN_PROXY_FOR_VIDEO 0'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:35' included forbidden macro 'ENABLE' => '#if ENABLE_PLUGIN_PROXY_FOR_VIDEO'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:45' included forbidden macro 'ENABLE' => '#if ENABLE_PLUGIN_PROXY_FOR_VIDEO'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:31' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_DASHBOARD_SUPPORT)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:32' included forbidden macro 'ENABLE' => '#define ENABLE_DASHBOARD_SUPPORT 1'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:35' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_FULLSCREEN_API)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:36' included forbidden macro 'ENABLE' => '#define ENABLE_FULLSCREEN_API 1'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:130' included forbidden macro 'ENABLE' => '#if ENABLE_FULLSCREEN_API'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:173' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:238' included forbidden macro 'ENABLE' => '#if ENABLE_FULLSCREEN_API'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:33' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_DASHBOARD_SUPPORT)'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:34' included forbidden macro 'ENABLE' => '#define ENABLE_DASHBOARD_SUPPORT 1'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:73' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:360' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
>     ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:461' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'

We should double-check, but most of these failures are likely approved workarounds for not using the ENABLE() macros themselves.  If so, the script shouldn't be flagging them as issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.