[Webkit-unassigned] [Bug 105342] New: [Mac] Remove Platform.h macros from WebKit Private Headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105342

           Summary: [Mac] Remove Platform.h macros from WebKit Private
                    Headers
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org


WebKit's public headers are free of Platform.h/Compiler.h macros, but it has a few uses in its private headers. This should be cleaned up and "PrivateHeaders" added to the check for macros build phase.

Note: the top 2 instances are actual uses, the rest appear to be directly defined flags. If those are safe, the script should be updated to not consider those errors.

    shell> TARGET_BUILD_DIR="$build/Release" PROJECT_NAME="WebKit" SHALLOW_BUNDLE="NO" ./Tools/Scripts/check-for-inappropriate-macros-in-external-headers PrivateHeaders
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/DOMDocumentPrivate.h:50' included forbidden macro 'ENABLE' => '#if ENABLE(POINTER_LOCK)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/DOMDocumentPrivate.h:53' included forbidden macro 'ENABLE' => '#if ENABLE(CSS_REGIONS)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDashboardRegion.h:26' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_DASHBOARD_SUPPORT)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDashboardRegion.h:27' included forbidden macro 'ENABLE' => '#define ENABLE_DASHBOARD_SUPPORT 1'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDashboardRegion.h:30' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebDatabaseManagerPrivate.h:29' included forbidden macro 'ENABLE' => '#if ENABLE(SQL_DATABASE)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebFramePrivate.h:34' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_NETSCAPE_PLUGIN_API)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebFramePrivate.h:35' included forbidden macro 'ENABLE' => '#define ENABLE_NETSCAPE_PLUGIN_API 1'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebFramePrivate.h:90' included forbidden macro 'ENABLE' => '#if ENABLE_NETSCAPE_PLUGIN_API'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebHTMLViewPrivate.h:31' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_NETSCAPE_PLUGIN_API)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebHTMLViewPrivate.h:32' included forbidden macro 'ENABLE' => '#define ENABLE_NETSCAPE_PLUGIN_API 1'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebHTMLViewPrivate.h:112' included forbidden macro 'ENABLE' => '#if ENABLE_NETSCAPE_PLUGIN_API'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:31' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_PLUGIN_PROXY_FOR_VIDEO)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:32' included forbidden macro 'ENABLE' => '#define ENABLE_PLUGIN_PROXY_FOR_VIDEO 0'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:35' included forbidden macro 'ENABLE' => '#if ENABLE_PLUGIN_PROXY_FOR_VIDEO'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebPluginContainerPrivate.h:45' included forbidden macro 'ENABLE' => '#if ENABLE_PLUGIN_PROXY_FOR_VIDEO'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:31' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_DASHBOARD_SUPPORT)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:32' included forbidden macro 'ENABLE' => '#define ENABLE_DASHBOARD_SUPPORT 1'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:35' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_FULLSCREEN_API)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:36' included forbidden macro 'ENABLE' => '#define ENABLE_FULLSCREEN_API 1'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:130' included forbidden macro 'ENABLE' => '#if ENABLE_FULLSCREEN_API'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:173' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebUIDelegatePrivate.h:238' included forbidden macro 'ENABLE' => '#if ENABLE_FULLSCREEN_API'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:33' included forbidden macro 'ENABLE' => '#if !defined(ENABLE_DASHBOARD_SUPPORT)'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:34' included forbidden macro 'ENABLE' => '#define ENABLE_DASHBOARD_SUPPORT 1'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:73' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:360' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'
    ERROR: 'WebKit.framework/Versions/A/PrivateHeaders/WebViewPrivate.h:461' included forbidden macro 'ENABLE' => '#if ENABLE_DASHBOARD_SUPPORT'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.