[Webkit-unassigned] [Bug 61862] EventSource should support CORS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61862


Per-Erik Brodin <per-erik.brodin at ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179305|0                           |1
        is obsolete|                            |
 Attachment #179305|review?                     |
               Flag|                            |
 Attachment #180024|                            |review?, commit-queue?
               Flag|                            |




--- Comment #47 from Per-Erik Brodin <per-erik.brodin at ericsson.com>  2012-12-18 14:15:22 PST ---
Created an attachment (id=180024)
 --> (https://bugs.webkit.org/attachment.cgi?id=180024&action=review)
patch 8

(In reply to comment #46)
> > LayoutTests/http/tests/eventsource/eventsource-cors-no-server-expected.txt:3
> > +FAIL: got error event but readyState is CONNECTING
> 
> Is this OK?
The failing test was originally for bug 70112 and my plan was to update the expected result when fixing that one. However, the spec changed recently so the current behavior is correct.
I have updated the test accordingly.

> 
> > Source/WebCore/page/EventSource.cpp:124
> > +    options.allowCredentials = origin->canRequest(m_url) || m_withCredentials ? AllowStoredCredentials : DoNotAllowStoredCredentials;
> 
> I would put braces around the condition for clarity (and because this makes it look more like an if () condition).

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.