[Webkit-unassigned] [Bug 61862] EventSource should support CORS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61862





--- Comment #46 from Alexey Proskuryakov <ap at webkit.org>  2012-12-17 13:45:05 PST ---
(From update of attachment 179305)
View in context: https://bugs.webkit.org/attachment.cgi?id=179305&action=review

Looks good to me, except for failing test. Sorry for the delay.

> LayoutTests/http/tests/eventsource/eventsource-cors-no-server-expected.txt:3
> +FAIL: got error event but readyState is CONNECTING

Is this OK?

> Source/WebCore/page/EventSource.cpp:124
> +    options.allowCredentials = origin->canRequest(m_url) || m_withCredentials ? AllowStoredCredentials : DoNotAllowStoredCredentials;

I would put braces around the condition for clarity (and because this makes it look more like an if () condition).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.