[Webkit-unassigned] [Bug 104354] IndexedDB: Don't use strings to represent serialized values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104354





--- Comment #15 from Kentaro Hara <haraken at chromium.org>  2012-12-12 23:32:03 PST ---
(From update of attachment 178915)
View in context: https://bugs.webkit.org/attachment.cgi?id=178915&action=review

(It looks like a couple of my comments were gone away...)

> Source/WebCore/bindings/js/SerializedScriptValue.h:107
> +    static PassRefPtr<SerializedScriptValue> createFromWire(const Vector<uint8_t>& data)

It's a bit confusing that there are two createFromWire()s. Shall we rename the method?

> Source/WebCore/bindings/js/SerializedScriptValue.h:112
> +    const Vector<uint8_t>& toWireBytes() const { return m_data; }

Is this correct? You're implementing toWireBytes() in the cpp file too.

> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:2326
> +    return result;

Can we avoid copying the vector ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.