[Webkit-unassigned] [Bug 104354] IndexedDB: Don't use strings to represent serialized values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104354


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178915|review?                     |review-
               Flag|                            |




--- Comment #14 from Kentaro Hara <haraken at chromium.org>  2012-12-12 23:29:36 PST ---
(From update of attachment 178915)
View in context: https://bugs.webkit.org/attachment.cgi?id=178915&action=review

BTW, don't you have any performance concern about this change? (Is there any benchmark that we can use to make sure that this change won't regress performance?)

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1406
> +    Vector<uint8_t> m_emptyValue;

Do you need this member?

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1528
> +    Vector<uint8_t> m_emptyValue;

Ditto.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1610
> +    Vector<uint8_t> m_value;

Nit: Rename to m_currentValue, as you're using m_currentValue above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.