[Webkit-unassigned] [Bug 104366] Make order iterator member stack allocated in RenderFlexibleBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104366





--- Comment #9 from Tony Chang <tony at chromium.org>  2012-12-07 12:21:09 PST ---
(In reply to comment #8)
> (From update of attachment 178209 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178209&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        (WebCore::RenderFlexibleBox::baselinePosition): Make it non const
> > +        because the order iterator is modified.
> 
> This doesn't work because now it's not actually overriding the parent class's virtual baselinePosition method. constness has to match. I'm not what you should do instead. :(

I would probably make m_orderIterator mutable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.