[Webkit-unassigned] [Bug 104366] Make order iterator member stack allocated in RenderFlexibleBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104366


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178209|review?                     |review-
               Flag|                            |




--- Comment #8 from Ojan Vafai <ojan at chromium.org>  2012-12-07 12:18:17 PST ---
(From update of attachment 178209)
View in context: https://bugs.webkit.org/attachment.cgi?id=178209&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::RenderFlexibleBox::baselinePosition): Make it non const
> +        because the order iterator is modified.

This doesn't work because now it's not actually overriding the parent class's virtual baselinePosition method. constness has to match. I'm not what you should do instead. :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.