[Webkit-unassigned] [Bug 103555] Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103555





--- Comment #28 from Hin-Chung Lam <hclam at google.com>  2012-12-06 14:30:27 PST ---
(In reply to comment #27)
> (From update of attachment 176569 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176569&action=review
> 
> > Source/WebCore/platform/graphics/chromium/LazyDecodingPixelRef.cpp:97
> > +    return ImageDecodingStore::instance()->lockCompleteCache(m_frameGenerator.get(), m_scaledSize);
> 
> I don't think this is entirely correct, this method is used as a hint to see of the cache is there. So the code should be:
> 
> const ScaledImageFragment* cachedImage = ...lockCompleteCache();
> if (!cachedImage)
>   return false;
> ... unlockCache(cachedImage);
> return true;
> 
> Can you make another change to fix this?

If you don't do this it wil leak.. :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.