[Webkit-unassigned] [Bug 103555] Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 14:27:11 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103555





--- Comment #27 from Hin-Chung Lam <hclam at google.com>  2012-12-06 14:29:39 PST ---
(From update of attachment 176569)
View in context: https://bugs.webkit.org/attachment.cgi?id=176569&action=review

> Source/WebCore/platform/graphics/chromium/LazyDecodingPixelRef.cpp:97
> +    return ImageDecodingStore::instance()->lockCompleteCache(m_frameGenerator.get(), m_scaledSize);

I don't think this is entirely correct, this method is used as a hint to see of the cache is there. So the code should be:

const ScaledImageFragment* cachedImage = ...lockCompleteCache();
if (!cachedImage)
  return false;
... unlockCache(cachedImage);
return true;

Can you make another change to fix this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list