[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603





--- Comment #23 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-08-27 01:22:55 PST ---
(From update of attachment 160621)
View in context: https://bugs.webkit.org/attachment.cgi?id=160621&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:33
> +    : m_view(view)

Check for null?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:64
> +    Ewk_Security_Origin* origin = ewk_security_origin_new(context->securityOrigin());

shouldn't we check args for null here before usage?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:80
> +void NotificationPresenterClientEfl::addToPermissionCache(const String domain, const bool isAllowed)

const String& domain

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:84
> +        return;

if (iter != m_cachedPermissions.end())
   m_cachedPermissions.add(domain, isAllowed);

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:90
> +    PermissionRequestMap::iterator iter = m_pendingPermissionRequests.find(const_cast<Ewk_Security_Origin*>(origin));

maybe typedef HashMap<const Ewk_Security_Origin*, RefPtr<WebCore::NotificationPermissionCallback> > PermissionRequestMap; so that you do not need const_cast?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.