[Webkit-unassigned] [Bug 91844] [EFL][WK2] Plugin process implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-22 02:44:42 PST ---
(From update of attachment 159885)
View in context: https://bugs.webkit.org/attachment.cgi?id=159885&action=review

> Source/WebKit2/PlatformEfl.cmake:92
> +    UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp

It would be good if you add a new line. Because cmake prefers to distinguish different path by a new line.

> Source/WebKit2/PlatformEfl.cmake:106
> +    WebProcess/Plugins/Netscape/efl/PluginProxyEfl.cpp

ditto.

> Source/WebKit2/PlatformEfl.cmake:236
> +        "${WEBKIT2_DIR}/PluginProcess/efl"

Generally, specific include path is placed above path defined by macro as below,

"${WEBKIT2_DIR}/PluginProcess/efl"
${WEBKIT2_DIR}

> Source/WebKit2/PluginProcess/efl/PluginControllerProxyEfl.cpp:31
> +#if ENABLE(PLUGIN_PROCESS)

Please add a new line.

> Source/WebKit2/PluginProcess/efl/PluginControllerProxyEfl.cpp:33
> +

This is unneeded line.

> Source/WebKit2/PluginProcess/efl/PluginProcessMainEfl.cpp:30
> +

Don't you need to use ENABLE(PLUGIN_PROCESS) ?

> Source/WebKit2/PluginProcess/efl/PluginProcessMainEfl.cpp:80
> +

This is unneeded line.

> Source/WebKit2/UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp:61
> +

If you need to use glib function, I think you need to use #if ENABLE(GLIB_SUPPORT) macro.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.