[Webkit-unassigned] [Bug 72811] [Gtk] No accessible caret-moved events found in certain content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72811





--- Comment #16 from chris fleizach <cfleizach at apple.com>  2012-08-21 15:21:07 PST ---
(From update of attachment 159777)
View in context: https://bugs.webkit.org/attachment.cgi?id=159777&action=review

> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:860
> +                    || role == ParagraphRole || role == HeadingRole || role == DivRole || role == CellRole)

having an && and then an || without parenthesis makes it ambiguous which will be interpreted first (so we should add parens around the renderer && render->childrenInline)

I also think you should have a static method like roleIsTextType(AXRole role) instead of listing out each role here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.