[Webkit-unassigned] [Bug 72811] [Gtk] No accessible caret-moved events found in certain content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72811


Joanmarie Diggs <jdiggs at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159321|0                           |1
        is obsolete|                            |
 Attachment #159342|0                           |1
        is obsolete|                            |




--- Comment #15 from Joanmarie Diggs <jdiggs at igalia.com>  2012-08-21 15:18:18 PST ---
Created an attachment (id=159777)
 --> (https://bugs.webkit.org/attachment.cgi?id=159777&action=review)
Fix for the failure to implement AtkText along with updated unit test

This patch addresses the AtkText issue.

Given this some further thought this situation is as follows:
  * It the object is not ignored, AND
  * If the object is a paragraph, heading, div, table cell, or list item THEN
  * It should claim to implement AtkText -- regardless of whether or not it has text
  * If it doesn't actually have text, it should claim to have 0 chars and an empty string

FWIW: This is what we see from LibreOffice and it is what we see from Gecko. (Not that either can be counted upon for always doing what is right, but in this case I do think it is right.)

Therefore this patch just does a simple role check for paragraph, heading, div, and cell. The reason I did not do it for list item is listitem is that role already has role-specific code that causes it to do the right thing.

Please review. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.