[Webkit-unassigned] [Bug 93496] [BlackBerry] Add RSS content handling support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93496





--- Comment #8 from Rob Buis <rwlbuis at gmail.com>  2012-08-21 10:18:40 PST ---
> > > Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp:67
> > > +static int isspaceSafe(int ch)
> > 
> > What is meant here by "Safe"?
> 
> The "Safe" means just the lowest byte is checked. But I agree it is not very descriptive and I am open to better names.

Something like isASCIISpaceLowerByte would be better.

> > > Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.h:32
> > > +        TYPE_UNKNOWN = 0,
> > 
> > The = 0 is not strictly needed.
> 
> It seems quite some enum in WebKit has the first value = 0 style. And in all my codes I use this style. So I am not sure whether I should change it. But if you feel remove this "= 0," is desired, I can remove it.

Yes please remove the = 0, also use camelCase for enum values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.