[Webkit-unassigned] [Bug 93496] [BlackBerry] Add RSS content handling support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93496


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159596|review?                     |review-
               Flag|                            |




--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-08-21 08:21:36 PST ---
(From update of attachment 159596)
View in context: https://bugs.webkit.org/attachment.cgi?id=159596&action=review

Looks good, can do with some more cleanup.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:37
> +#include "rss/RSSFilterStream.h"

I am not sure that you need to do this, the PlatformBlackBerry.cmake change suggests you can leave the rss/ off.

> Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp:62
> +static inline bool isControlCharacter(int data)

I wonder if there is a stdlib function for this.

> Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp:67
> +static int isspaceSafe(int ch)

What is meant here by "Safe"?

> Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp:117
> +    for (size_t start = 0, delimiter = 0;delimiter != std::string::npos; start = delimiter + 1) {

Fix spacing please ; delimiter

> Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp:326
> +        || (!strcasecmp(language, "en-US")))

No need to wrap this line.

> Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp:667
> +        // make sure the headers are never sent twice

Please try to make all comments end with a period and start with a capital. Right now it is a bit inconsistent.

> Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.h:32
> +        TYPE_UNKNOWN = 0,

The = 0 is not strictly needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.