[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819





--- Comment #29 from chris fleizach <cfleizach at apple.com>  2012-08-20 18:48:02 PST ---
(From update of attachment 159484)
View in context: https://bugs.webkit.org/attachment.cgi?id=159484&action=review

looking good, besides minor nits. i think you might want to wait for someone on the google CC list to review the chromium change, although I'm sure it will be fine

> Source/WebCore/accessibility/AccessibilityObject.cpp:1743
> +// This method assumes that the object is already a button-related

I think this comment is probably not needed. it just explains what the code does, which is pretty easy to read.

> Source/WebCore/accessibility/AccessibilityObject.cpp:1750
> +    // If aria-pressed is present, then it should be exposed as a toggle button.

you could ASSERT(isButton()) and return UnknownRole if not a button

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.