[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819


Alejandro Piñeiro <apinheiro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159393|0                           |1
        is obsolete|                            |
 Attachment #159393|review?                     |
               Flag|                            |
 Attachment #159484|                            |review?
               Flag|                            |




--- Comment #28 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-08-20 12:03:43 PST ---
Created an attachment (id=159484)
 --> (https://bugs.webkit.org/attachment.cgi?id=159484&action=review)
Fixes the bug

Updated patch based on comment 26 review.

I didn't add a ariaHasPressedState as suggested, because as I explain in comment 27, this is confusing with ariaHasPopup(). The method I'm adding checks if an attribute is present, ariaHasPopup checks if has-popup attribute is true.

So I added a method called ariaPressedIsPresent (I felt that ariaPressedAttributeIsPresent was too long).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.