[Webkit-unassigned] [Bug 91052] JSC: LLInt should auto-generate our cross-platform C++ interpreter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91052





--- Comment #21 from Filip Pizlo <fpizlo at apple.com>  2012-08-20 15:24:55 PST ---
(In reply to comment #20)
> (In reply to comment #18)
> > Here's a specific suggestion for making this more readable. Instead of:
> > 
> >     r4.i = *CAST<intptr_t*>(r0.i8p);                           //   next<a5> = result<a3>.ptr;
> >     *CAST<intptr_t*>(r1.i8p + 1680) = r4.i;                    //   globalData<a4>.MySizeClass.FirstFreeCell = next<a5>;
> > 
> > How about:
> > 
> >     loadp(r4, address(r0));
> >     storei(address(r1, 1680), r4);
> 
> Are you suggesting that I make the output look more like ASM code?  I can do that if its preferable.

I vote for not making this change; I think it's good as-is.  In my experience, we rarely look at the generated code.  And when we do, I think it's better to see exactly what the code is doing, which your form is good for.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.