[Webkit-unassigned] [Bug 94471] [GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94471





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-08-20 08:07:10 PST ---
(In reply to comment #3)
> (From update of attachment 159403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159403&action=review
> 
> Thanks!
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1554
> > + * error page, the the back-forward list is maintained appropriately.
> 
> Hrm. Would it make sense to just say outright something like, "When this method is called, a new entry is added to the back-forward list." ?

It's more complicated than that, when alternate string is called from a load error callback, going back/forward from a load error page convert the load into a reload to avoid a new time to be added to the back forward list. See this bug:

https://bugs.webkit.org/show_bug.cgi?id=94476

Because it's currently broken in wk2, and see the implementation here:

http://trac.webkit.org/browser/trunk/Source/WebCore/loader/FrameLoader.cpp

So, I copied the description from the wk1 mac docs:

https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/WebKit/ObjC_classic/_index.html

I plan to add a unit test for that case, skipped until bug #94476 is fixed.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1555
> > + * For everything else this method works the same way than webkit_web_view_load_html().
> 
> Nit: same way than -> same way as

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.