[Webkit-unassigned] [Bug 94471] [GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 07:22:15 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94471


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159403|review?                     |review+
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2012-08-20 07:22:50 PST ---
(From update of attachment 159403)
View in context: https://bugs.webkit.org/attachment.cgi?id=159403&action=review

Thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1554
> + * error page, the the back-forward list is maintained appropriately.

Hrm. Would it make sense to just say outright something like, "When this method is called, a new entry is added to the back-forward list." ?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1555
> + * For everything else this method works the same way than webkit_web_view_load_html().

Nit: same way than -> same way as

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list