[Webkit-unassigned] [Bug 91912] Adding "all" to -webkit-user-select

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91912





--- Comment #33 from Ryosuke Niwa <rniwa at webkit.org>  2012-08-16 15:28:39 PST ---
(In reply to comment #32)
> (From update of attachment 158896 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158896&action=review
> 
> Thanks for your reply, Ryosuke, more questions:
> 
> >>>> Source/WebCore/dom/Position.cpp:886
> >>>> +    while (parent && Position::nodeIsUserSelectAll(parent)) {
> >>> 
> >>> Ditto about Position:: and needing a test.
> >> 
> >> I think it is tested in LayoutTests/editing/selection/user-select-all-selection.html, but I do need to modify that html to be more readable. Or is there an additional test needed?
> > 
> > We don't have test cases where some of ancestors already have -webkit-user-select: all.
> 
> <span class="userSelectAll" id ="allArea"> is the ancestor of the text nodes, anchor node, and br node (user select all area<br><a href="#">user select all area</a>). Doest that count?

No, the case I'm thinking of is with
<span style="-webkit-user-select: all;">hello <span style="-webkit-user-select: all;">world</span> world</span>
and you click somewhere in "world".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.