[Webkit-unassigned] [Bug 91912] Adding "all" to -webkit-user-select

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91912





--- Comment #32 from Alice Cheng <alice_cheng at apple.com>  2012-08-16 15:26:11 PST ---
(From update of attachment 158896)
View in context: https://bugs.webkit.org/attachment.cgi?id=158896&action=review

Thanks for your reply, Ryosuke, more questions:

>>>> Source/WebCore/dom/Position.cpp:886
>>>> +    while (parent && Position::nodeIsUserSelectAll(parent)) {
>>> 
>>> Ditto about Position:: and needing a test.
>> 
>> I think it is tested in LayoutTests/editing/selection/user-select-all-selection.html, but I do need to modify that html to be more readable. Or is there an additional test needed?
> 
> We don't have test cases where some of ancestors already have -webkit-user-select: all.

<span class="userSelectAll" id ="allArea"> is the ancestor of the text nodes, anchor node, and br node (user select all area<br><a href="#">user select all area</a>). Doest that count?
My mouse test (click) tests on clicking on text node of the span, which has ancestor span node.

>>>> Source/WebCore/page/EventHandler.cpp:442
>>>>          updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, WordGranularity);
>>> 
>>> Why don't we call this in updateSelectionForMouseDownDispatchingSelectStart instead of repeating it everywhere?
>> 
>> Because the VisibleSelection in updateSelectionForMouseDownDispatchingSelectStart is passed in as a constant reference, and therefore I cannot change it there. Do you want me to remove the const and call it there?
> 
> Why do you need to modify newSelection? You can just create a local copy and modify that instead.

sounds good. will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.