[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819


Alejandro Piñeiro <apinheiro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158769|                            |review?
               Flag|                            |




--- Comment #16 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-08-16 03:58:23 PST ---
Created an attachment (id=158769)
 --> (https://bugs.webkit.org/attachment.cgi?id=158769&action=review)
Fixes the bug

(In reply to comment #15)
> (In reply to comment #14)
> > 
> > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:495
> > > > +}
> > > 
> > > I think isButton() already returns true if ariaRoleAttribute is button.
> 
> What about this comment?

True, I have simplified the check on the fuction.

> > > > Source/WebCore/accessibility/AccessibilityRenderObject.h:74
> > > > +    virtual bool isToggleButton() const;
> > > 
> > > this should probably be private
> > 
> 
> I think you wan to leave it public on AccessibilityObject, but make it private on AccessibilityRenderObject.

Ok. Now isToggleButton is public on AccessibilityObject but private on AccessibilityRenderObject.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.