[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819





--- Comment #15 from chris fleizach <cfleizach at apple.com>  2012-08-15 08:06:56 PST ---
(In reply to comment #14)
> 
> > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:495
> > > +}
> > 
> > I think isButton() already returns true if ariaRoleAttribute is button.

What about this comment?

> 
> > > Source/WebCore/accessibility/AccessibilityRenderObject.h:74
> > > +    virtual bool isToggleButton() const;
> > 
> > this should probably be private
> 

I think you wan to leave it public on AccessibilityObject, but make it private on AccessibilityRenderObject.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.