[Webkit-unassigned] [Bug 94058] [BlackBerry] [DRT] 5 tests failed for incorrect JS console message format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94058





--- Comment #5 from Xiaobo Wang <xiaobo.wang at torchmobile.com.cn>  2012-08-15 19:22:09 PST ---
(In reply to comment #4)
> (From update of attachment 158486 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158486&action=review
> 
> > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:653
> > +        String remaining = message.substring(pos, message.length() - pos);
> 
> ", message.length() - pos" is not necessary
> 
> > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:657
> > +            baseName = remaining.substring(indexBase + 1, remaining.length() - indexBase - 1);
> 
> ditto. Also it should be called "fileName" rather than "baseName"? "Base" sounds like base URL / the folder path...

Good suggestions Yong. I agree "fileName" is better. Actually I borrowed the name from the UNIX command "basename" which usually returns the file name of a full path. Will update the patch soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.