[Webkit-unassigned] [Bug 94058] [BlackBerry] [DRT] 5 tests failed for incorrect JS console message format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94058





--- Comment #4 from Yong Li <yoli at rim.com>  2012-08-15 07:08:38 PST ---
(From update of attachment 158486)
View in context: https://bugs.webkit.org/attachment.cgi?id=158486&action=review

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:653
> +        String remaining = message.substring(pos, message.length() - pos);

", message.length() - pos" is not necessary

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:657
> +            baseName = remaining.substring(indexBase + 1, remaining.length() - indexBase - 1);

ditto. Also it should be called "fileName" rather than "baseName"? "Base" sounds like base URL / the folder path...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.