[Webkit-unassigned] [Bug 83435] [Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 02:11:22 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83435





--- Comment #5 from Joanmarie Diggs <jdiggs at igalia.com>  2012-08-15 02:11:55 PST ---
(In reply to comment #4)
> (From update of attachment 158452 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158452&action=review
> 
> Thanks for the patch. It looks good to me with the exception of the missing comments in the ChangeLog.

Thanks for the review! :) Perhaps I should have coffee first and then respond, but.... What missing comments?

Looking at: https://bugs.webkit.org/attachment.cgi?id=158452&action=prettypatch, I see:

    Source/WebCore/ChangeLog
    8        Be sure the list item marker to be ignored is actually a list item marker prior to ignoring it.

    Source/WebKit/gtk/ChangeLog
    8        Include a paragraph in a list item when testing atk_text_get_text_at_offset().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list