[Webkit-unassigned] [Bug 83435] [Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83435





--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2012-08-15 01:39:02 PST ---
(From update of attachment 158452)
View in context: https://bugs.webkit.org/attachment.cgi?id=158452&action=review

Thanks for the patch. It looks good to me with the exception of the missing comments in the ChangeLog.

You should still ask for an official review, though

> Source/WebCore/ChangeLog:11
> +        (textForRenderer):

A brief description of the change for textForRenderer would be nice here.

> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:82
> +            if (object->isReplaced() && !object->isListMarker())

Oh! It indeed looks like a mistake in the code (and not coherent withthe comment).

Good catch (/me runs and hides)

> Source/WebKit/gtk/ChangeLog:11
> +        (testWebkitAtkGetTextAtOffsetWithSpecialCharacters):

Something like "Updated unit test" would be nice here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.