[Webkit-unassigned] [Bug 74346] Text selection in text area in auto scroll mode goes wrong.

Tue Aug 14 21:17:52 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=74346

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158495|review?                     |review+
               Flag|                            |

--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2012-08-14 21:18:21 PST ---
(From update of attachment 158495)
View in context: https://bugs.webkit.org/attachment.cgi?id=158495&action=review

Looks great. Please address my last comments on the test and then feel free to commit.

Just to be sure, you verified that the test still fails without your fix and without the setTimeout, right? :)

> LayoutTests/fast/events/autoscroll-in-textarea.html:1
> +<!doctype html>

Nit: typically we uppercase doctype:
<!DOCTYPE html>

> LayoutTests/fast/events/autoscroll-in-textarea.html:42
> +    testRunner.waitUntilDone();

Now that you don't have the setTimeout, you don't need this line.

> LayoutTests/fast/events/autoscroll-in-textarea.html:69
> +if (window.testRunner)
> +    testRunner.notifyDone();

and without the waitUntilDone call above, you don't need to notifyDone either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.