[Webkit-unassigned] [Bug 74346] Text selection in text area in auto scroll mode goes wrong.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74346





--- Comment #4 from Sukolsak Sakshuwong <sukolsak at google.com>  2012-08-14 21:10:25 PST ---
(In reply to comment #2)
> (From update of attachment 157713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157713&action=review
> 
> R- for the 100ms timeout. The C++ side looks good to me.
> 
> > LayoutTests/fast/events/autoscroll-in-textarea.html:57
> > +        var x = textarea.offsetLeft + 20;
> > +        var y = textarea.offsetTop + 8;
> 
> Can you make these less magic? For x, you can do textarea.offsetLeft + textarea.offsetWidth / 2.
> 
> For y, would adding 1 be enough?
> 
> > LayoutTests/fast/events/autoscroll-in-textarea.html:63
> > +    setTimeout(autoscrollTestPart2, 100);
> 
> Do you need this 100ms? 0 should be sufficient I would think. No need to make the test take ~100ms longer.

Fixed. Thank you for the comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.