[Webkit-unassigned] [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51450





--- Comment #39 from Koji Ishii <kojiishi at gmail.com>  2012-08-11 17:00:34 PST ---
(From update of attachment 157870)
View in context: https://bugs.webkit.org/attachment.cgi?id=157870&action=review

>> Source/WebCore/WebCore.gyp/WebCore.gyp:1829
>> +        }],
> 
> You don't need to add new OS==win conditional block.  We should add these files in the existing OS==win conditional block above.

Thank you Kent for the prompt advice, fixed.

>> Source/WebCore/config.h:166
>> +#endif
> 
> I prefer adding ENABLE_OPENTYPE_VERTICAL to Source/WebKit/chromium/features.gypi.

Thank you for this one too, fixed.

>> Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:39
>> +#include "FontCache.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

I suppose this is a false alarm as files above are Windows header file and uses <>.
Should I fix this? If so, how? Advices are appreciated in advance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.