[Webkit-unassigned] [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51450





--- Comment #38 from Kent Tamura <tkent at chromium.org>  2012-08-11 06:13:11 PST ---
(From update of attachment 157870)
View in context: https://bugs.webkit.org/attachment.cgi?id=157870&action=review

> Source/WebCore/WebCore.gyp/WebCore.gyp:1829
> +        ['OS=="win"', {
> +          'sources/': [
> +            ['include', 'platform/graphics/opentype/OpenTypeTypes\\.h$'],
> +            ['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.cpp$'],
> +            ['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.h$'],
> +          ],
> +        }],

You don't need to add new OS==win conditional block.  We should add these files in the existing OS==win conditional block above.

> Source/WebCore/config.h:166
> +/* Vertical text flow for OpenType fonts using our own code */
> +#if PLATFORM(CHROMIUM) && OS(WINDOWS)
> +#define ENABLE_OPENTYPE_VERTICAL 1
> +#endif

I prefer adding ENABLE_OPENTYPE_VERTICAL to Source/WebKit/chromium/features.gypi.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.