[Webkit-unassigned] [Bug 93731] Use static AtomicString's for http header keys and values
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 10 13:32:58 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=93731
--- Comment #6 from Yong Li <yoli at rim.com> 2012-08-10 13:33:26 PST ---
(In reply to comment #5)
> (From update of attachment 157774 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157774&action=review
>
> I don't know. Probably not much harm, and not much good.
>
> Note however that the current patch is strictly a regression. These AtomicStrings have a regular hash pre-calculated, but HashMap uses CaseFoldingHash. So, the pre-caclculated hash will not be used.
Bang! I forgot this..
>
> > Source/WebCore/platform/network/ResourceRequestBase.cpp:43
> > +AtomicString* ResourceRequestBase::headerNameAccept = new AtomicString("Accept");
>
> This is not OK - we can not have global with initializers. No code should be run when WebKit shared library loads.
>
> You'll probably need a new file similar to HTMLNames.h.
Thanks!
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list