[Webkit-unassigned] [Bug 93731] Use static AtomicString's for http header keys and values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93731





--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2012-08-10 13:13:52 PST ---
(From update of attachment 157774)
View in context: https://bugs.webkit.org/attachment.cgi?id=157774&action=review

I don't know. Probably not much harm, and not much good.

Note however that the current patch is strictly a regression. These AtomicStrings have a regular hash pre-calculated, but HashMap uses CaseFoldingHash. So, the pre-caclculated hash will not be used.

Generally, it's much easier to start with profiler data and optimize that's taking significant time than to figure out whether a random change improves performance.

> Source/WebCore/platform/network/ResourceRequestBase.cpp:43
> +AtomicString* ResourceRequestBase::headerNameAccept = new AtomicString("Accept");

This is not OK - we can not have global with initializers. No code should be run when WebKit shared library loads.

You'll probably need a new file similar to HTMLNames.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.