[Webkit-unassigned] [Bug 93629] Reduce Font.h includes across project -- improves RenderObject.h compile time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93629





--- Comment #18 from nbhargava at google.com  2012-08-10 11:41:09 PST ---
I plan to run performance tests soon in order to check whether the de-inlining causes a regression in performance. I'm having a little trouble though and am waiting for rniwa for some guidance on those. In the mean time I just want to make sure that it passes EWS since I'd have to do that anyways if there are no performance impacts.

My bad on the other two things. Will fix those.

(In reply to comment #17)
> (From update of attachment 157767 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157767&action=review
> 
> I agree with Eric that de-inlining functions looks suspicious.
> 
> > Source/WebCore/ChangeLog:6
> > +        Reviewed by NOBODY (OOPS!).
> 
> This patch has never been r+ed as far as I can tell - why do you not set the "review?" flag any more?
> 
> > Source/WebCore/ChangeLog:8
> > +        RenderStyle.cpp and RenderStyle.h are modified to remove dependencies onFont.h. The remaining files are cleaned up if they do need Font.h. The biggest impact is that RenderObject.h no longer always includes Font.h
> 
> This line is long, please wrap it to the regular width as seen in other entries.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.