[Webkit-unassigned] [Bug 93629] Reduce Font.h includes across project -- improves RenderObject.h compile time

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 11:31:44 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93629





--- Comment #17 from Alexey Proskuryakov <ap at webkit.org>  2012-08-10 11:32:09 PST ---
(From update of attachment 157767)
View in context: https://bugs.webkit.org/attachment.cgi?id=157767&action=review

I agree with Eric that de-inlining functions looks suspicious.

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

This patch has never been r+ed as far as I can tell - why do you not set the "review?" flag any more?

> Source/WebCore/ChangeLog:8
> +        RenderStyle.cpp and RenderStyle.h are modified to remove dependencies onFont.h. The remaining files are cleaned up if they do need Font.h. The biggest impact is that RenderObject.h no longer always includes Font.h

This line is long, please wrap it to the regular width as seen in other entries.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list