[Webkit-unassigned] [Bug 93467] Change ImageSource to be asynchronous.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 9 13:36:51 PDT 2012


--- Comment #7 from James Robinson <jamesr at chromium.org>  2012-08-09 13:37:17 PST ---
(From update of attachment 157406)
View in context: https://bugs.webkit.org/attachment.cgi?id=157406&action=review

> Source/WebCore/platform/graphics/BitmapImage.h:185
> +    virtual void didDecodeFrameAtIndex(size_t, NativeImagePtr);

please add OVERRIDE annotation when you're overriding a virtual. It goes after the signature but before the ;

> Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp:60
> +        SynchronousImageSource decoder(ImageSource::AlphaNotPremultiplied,
>                              ignoreGammaAndColorProfile ? ImageSource::GammaAndColorProfileIgnored : ImageSource::GammaAndColorProfileApplied);

please make the parameter line up with opening ( as it did before the type name change

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list